Add commit signing #155
Add commit signing #155
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 4 | 0 | 0.1s | |
| scss-lint | 2 | 1 | 3.44s | ||
| ✅ JAVASCRIPT | prettier | 6 | 0 | 0 | 1.09s |
| ✅ JSON | jsonlint | 7 | 0 | 0.37s | |
| ✅ JSON | npm-package-json-lint | yes | no | 0.66s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 1.4s |
| ✅ JSON | v8r | 7 | 0 | 11.23s | |
| ✅ MARKDOWN | markdownlint | 20 | 0 | 0 | 1.98s |
| ✅ MARKDOWN | markdown-link-check | 20 | 0 | 10.24s | |
| ✅ MARKDOWN | markdown-table-formatter | 20 | 0 | 0 | 0.45s |
| ✅ REPOSITORY | checkov | yes | no | 14.75s | |
| ✅ REPOSITORY | gitleaks | yes | no | 0.2s | |
| ✅ REPOSITORY | git_diff | yes | no | 0.24s | |
| grype | yes | 3 | 14.3s | ||
| ✅ REPOSITORY | secretlint | yes | no | 2.59s | |
| trivy | yes | 1 | 9.1s | ||
| ✅ REPOSITORY | trivy-sbom | yes | no | 1.45s | |
| ✅ REPOSITORY | trufflehog | yes | no | 4.94s | |
| cspell | 20 | 1 | 2.7s | ||
| ✅ YAML | prettier | 14 | 0 | 0 | 1.47s |
| ✅ YAML | v8r | 11 | 0 | 13.23s | |
| ✅ YAML | yamllint | 14 | 0 | 0.61s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
Pa11y testing results``` Welcome to Pa11y
Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//sign_megalinter_keys/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. For over 50 years, GSA has been... • Error: Duplicate id attribute value "svg-bedding" found on the web page. • Error: Duplicate id attribute value "svg-camping" found on the web page. • Error: Duplicate id attribute value "svg-chevron_left" found on the web page. • Error: Duplicate id attribute value "svg-chevron_right" found on the web page. • Error: Duplicate id attribute value "svg-clothes" found on the web page. • Error: Duplicate id attribute value "svg-construction_worker" found on the web page. • Error: Duplicate id attribute value "svg-flickr" found on the web page. • Error: Duplicate id attribute value "svg-flooding" found on the web page. • Error: Duplicate id attribute value "svg-github" found on the web page. • Error: Duplicate id attribute value "svg-hospital" found on the web page. • Error: Duplicate id attribute value "svg-hurricane" found on the web page. • Error: Duplicate id attribute value "svg-identification" found on the web page. • Error: Duplicate id attribute value "svg-instagram" found on the web page. • Error: Duplicate id attribute value "svg-linkedin" found on the web page. • Error: Duplicate id attribute value "svg-navigate_far_before" found on the web page. • Error: Duplicate id attribute value "svg-navigate_far_next" found on the web page. • Error: Duplicate id attribute value "svg-rain" found on the web page. • Error: Duplicate id attribute value "svg-severe_weather" found on the web page. • Error: Duplicate id attribute value "svg-snow" found on the web page. • Error: Duplicate id attribute value "svg-sort_arrow" found on the web page. • Error: Duplicate id attribute value "svg-tornado" found on the web page. • Error: Duplicate id attribute value "svg-twitter" found on the web page. • Error: Duplicate id attribute value "svg-x" found on the web page. • Error: Duplicate id attribute value "svg-youtube" found on the web page. 25 Errors |
Pa11y testing results``` Welcome to Pa11y
Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//sign_megalinter_keys/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. For over 50 years, GSA has been... • Error: Duplicate id attribute value "svg-bedding" found on the web page. • Error: Duplicate id attribute value "svg-camping" found on the web page. • Error: Duplicate id attribute value "svg-chevron_left" found on the web page. • Error: Duplicate id attribute value "svg-chevron_right" found on the web page. • Error: Duplicate id attribute value "svg-clothes" found on the web page. • Error: Duplicate id attribute value "svg-construction_worker" found on the web page. • Error: Duplicate id attribute value "svg-flickr" found on the web page. • Error: Duplicate id attribute value "svg-flooding" found on the web page. • Error: Duplicate id attribute value "svg-github" found on the web page. • Error: Duplicate id attribute value "svg-hospital" found on the web page. • Error: Duplicate id attribute value "svg-hurricane" found on the web page. • Error: Duplicate id attribute value "svg-identification" found on the web page. • Error: Duplicate id attribute value "svg-instagram" found on the web page. • Error: Duplicate id attribute value "svg-linkedin" found on the web page. • Error: Duplicate id attribute value "svg-navigate_far_before" found on the web page. • Error: Duplicate id attribute value "svg-navigate_far_next" found on the web page. • Error: Duplicate id attribute value "svg-rain" found on the web page. • Error: Duplicate id attribute value "svg-severe_weather" found on the web page. • Error: Duplicate id attribute value "svg-snow" found on the web page. • Error: Duplicate id attribute value "svg-sort_arrow" found on the web page. • Error: Duplicate id attribute value "svg-tornado" found on the web page. • Error: Duplicate id attribute value "svg-twitter" found on the web page. • Error: Duplicate id attribute value "svg-x" found on the web page. • Error: Duplicate id attribute value "svg-youtube" found on the web page. 25 Errors |
|
This comment was for a different PR |
|
I closed the wrong PR. Oopsies. |
Pa11y testing results``` Welcome to Pa11y
Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//sign_megalinter_keys/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c. For over 50 years, GSA has been... 1 Errors |
|
The repo is configured to require that commits must be signed. Without signing, branches can't be merged:
Those unsigned commits are coming from MegaLinter:
|
This will add commit signing with a GPG key. Documentation on the commit action may be found here:
https://github.com/stefanzweifel/git-auto-commit-action#signing-commits
..and importing the GPG key may be found here:
https://github.com/crazy-max/ghaction-import-gpg
security considerations
This will help us maintain the "force signed commits" option.